pouchdb-community / pouchdb-replication-stream

Replicate PouchDB/CouchDB databases with Node.js-style streams
Apache License 2.0
189 stars 58 forks source link

Cleanups #6

Closed calvinmetcalf closed 10 years ago

calvinmetcalf commented 10 years ago

remember when I made snide comments about prototype and big boy JavaScript features? yeah that was me being wrong, thats fixed, also we use the line delineated json module and reexport pouchdb-stream so it's self contained like you wanted.

I also fix the tests and we use a stream that we both write to and then read from so we can avoid fs.

nolanlawson commented 10 years ago

Awesome, the tests seem to be passing except for coverage. I'll try to fix that later in the week.

Apology accepted about the snide comments. But then again, I was kinda hoping you'd come in and teach me a lesson. There's a reason I wrote a broken half-working version of this module and then asked you for input. ;)

calvinmetcalf commented 10 years ago

Actually it's even more broken On Sep 8, 2014 12:40 PM, "Nolan Lawson" notifications@github.com wrote:

Awesome, the tests seem to be passing except for coverage. I'll try to fix that later in the week.

Apology accepted about the snide comments. But then again, I was kinda hoping you'd come in and teach me a lesson. There's a reason I wrote a broken half-working version of this module and then asked you for input. ;)

— Reply to this email directly or view it on GitHub https://github.com/nolanlawson/pouchdb-replication-stream/pull/6#issuecomment-54875471 .

calvinmetcalf commented 10 years ago

And that's because I removed the part where we put stiffening the db

nolanlawson commented 10 years ago

Awesome, let's go with this.

nolanlawson commented 10 years ago

squashy-merged as 96b2d435f870c8182061965175af10dc5510f771