Closed calvinmetcalf closed 10 years ago
For the record, I actually like build tools, and this was an attempt to give my Jade-Angular-Yeoman seed a whirl. But yeah, for a small project like this that we can more easily host on GitHub Pages, directly modifying the HTML/CSS/JS code is fine.
It was nothing to do with build tools, it was the fact it was a static site that wasn't set up in a way to actually serve it statically, I'll often use browserify but have an index.html at the base of the repo so after I build I now have a worker static site.
On Thu, May 8, 2014 at 12:50 PM, Nolan Lawson notifications@github.comwrote:
For the record, I actually like build tools, and this was an attempt to give my Jade-Angular-Yeoman seedhttps://github.com/nolanlawson/yeoman-angular-jade-seeda whirl. But yeah, for a small project like this that we can more easily host on GitHub Pages, directly modifying the HTML/CSS/JS code is fine.
— Reply to this email directly or view it on GitHubhttps://github.com/pouchdb/npm-browser/pull/1#issuecomment-42574383 .
-Calvin W. Metcalf
we could have done the same thing here; just build and commit the static dist/
files to the gh-pages branch. But it's really not a big deal; I don't anticipate the app will get much bigger than it already is.
Also arguably it's better to just serve up the unminified files, because the point is to show people how easy it is to replicate npm using PouchDB; minified+concatenated js communicates that poorly.
after you merge it, you can make a gh-pages branch with it and move it over to the pouchdb org