search

pouchdb / pouchdb-auth

A PouchDB plug-in that simulates CouchDB's authentication daemon. Includes a users db that functions like CouchDB's.
36 stars 11 forks source link

Upgrade pouchdb-req-http-query #42

Closed linus closed 7 years ago

linus commented 7 years ago

Upgrade to version supporting PouchDB 6.x.

linus commented 7 years ago

This upgrades to a recent version of pouchdb-req-http-query, which relies on db.name instead of db.getUrl(). It seems to me that this will only work for pouchdb 6.x though, and the current version only works for earlier versions. I don't want to break other people's stuff and I am unsure if this will so please take a look at it if possible! Thanks!

marten-de-vries commented 7 years ago

As it's, as you said, technically a breaking change, you could change the version number of this package to 3.0.0 instead. Then you're allowed to break stuff according to http://semver.org/ (which node projects often use).

marten-de-vries commented 7 years ago

Otherwise, this looks fine to me.

linus commented 7 years ago

Great. I will publish it as version 3.0.0. Thanks