pouchdb / upsert

PouchDB plugin for upsert() and putIfNotExists() functions
Apache License 2.0
149 stars 25 forks source link

Make API consistent with 6.x pouchDB release #28

Closed bhaskarvk closed 7 years ago

bhaskarvk commented 7 years ago

The 6.x release has removed db.put(doc, id, rev) and replaced with db.put({_id: id, _rev: rev, data: 'foo'}) instead. The upsert and putIfAbsent API calls should be changed similarly and their implementation should call the new APIs accordingly.

nolanlawson commented 7 years ago

I'm sorry, but I don't actually see where in the code we are calling the old API? Seems to me we're already using the new API: https://github.com/pouchdb/upsert/blob/7493014d01420a6acdeeeec82d251dbd63b2adbb/index.js#L39

bhaskarvk commented 7 years ago

Sorry my bad!