search

pouchdb / upsert

PouchDB plugin for upsert() and putIfNotExists() functions
Apache License 2.0
149 stars 25 forks source link

Master branch is broken in Travis #34

Closed nolanlawson closed 7 years ago

nolanlawson commented 7 years ago

See https://github.com/pouchdb/upsert/pull/32 and https://github.com/pouchdb/upsert/pull/31

Apparently some dependency broke because this was green the last time the build ran. I've enabled GreenKeeper and we'll see if we can hunt this down.

nolanlawson commented 7 years ago

fixed in #33

nolanlawson commented 7 years ago

Nope, master is still broken. Apparently npm run test-browser passes on MacOS but fails on Travis Linux. Something different about Linux PhantomJS vs Mac PhanatomJS?

AndreaGi commented 7 years ago

@nolanlawson I don't think so, looks like more CouchDB is not running on Travis. Check the result on: https://travis-ci.org/pouchdb/upsert/jobs/207654791

I've opened an issue on TravicCI https://github.com/travis-ci/travis-ci/issues/7423

nolanlawson commented 7 years ago

Thanks for the tip, I believe the issue turned out to be that CORS wasn't enabled on the CouchDB, which would explain why it failed in the browser but worked in Node. I wonder why it ever worked in the first place; maybe a bug in old PhantomJS?

In any case #44 appears to fix it, so I'll close this.