search

pouetnet / pouet2.0

The next generation of trumpets. Now with 10% more whining sound.
http://www.pouet.net/
Other
141 stars 28 forks source link

Do not cut prod title if adding ellipsis would actually make it same length or longer #83

Closed sagamusix closed 5 years ago

sagamusix commented 5 years ago

votedis

We have accidentally replaced one k by three dots.

(and maybe using an actual ellipsis unicode symbol - i.e. … - would be nicer too.)

Gargaj commented 5 years ago

https://github.com/pouetnet/pouet2.0/blob/master/include_generic/functions.inc.php#L175

Not necessarily a fan of Unicode ellipses, because the function can't be sure if the output is HTML or UTF-8.

sagamusix commented 5 years ago

If you use … rather than … the output format shouldn't make a difference?

Gargaj commented 5 years ago

I would need to check the uses; there might be cases where the encoding is expected to be ASCII and not UTF8.