search

pouetnet / pouet2.0

The next generation of trumpets. Now with 10% more whining sound.
http://www.pouet.net/
Other
140 stars 28 forks source link

toplist.php date range checks addedDate instead of actual release date #88

Open psenough opened 5 years ago

psenough commented 5 years ago

toplist.php date range seems to be listing when prods were added to the database and not when they were first released.

as a result we get an empty list of everything released before the year 2000.

empty list: http://www.pouet.net/toplist.php?type=64k&platform=&limit=20&dateFrom=1991-02-01&dateTo=2000-02-01

proper list: http://www.pouet.net/toplist.php?type=64k&platform=&limit=20&dateFrom=1991-02-01&dateTo=2001-02-01

is this by design? if it is, maybe it should be said so more explicitly somewhere, so people searching for stuff from the 90s know about it while searching. if it's not, i can try to submit a patch for it, not sure if sql can handle mixing month and years without getting slow, will have to check.

or maybe this just ain't worth working on, since it's not really that used and it'll be deprecated by that proper prod query page that it's been talked about for a while now.

Gargaj commented 5 years ago

Release date is only accurate to mid-month though (the day is always 15th)

Gargaj commented 5 years ago

Also I just realized that the toplist sorting / 30-day rotation window is based on a formula using addedDate, so it's 1) not possible 2) your fault. :)

psenough commented 5 years ago

i could have fixed that legacy code when i had a chance yeah. would affect lot of pages to change it now. dont remember how sort is done on groups and lists but i think its on php post query. maybe need to create new column (proper datetime) comparableDate, calculate it on edit and add, and a script to batch convert, default all days to 15th or something. should be doable just yet another dirty hack. wondering if there is any sql temp table trickery to do it on the fly without long loading times though.

Sent from my iPhone

On 11 May 2019, at 19:03, Gargaj notifications@github.com wrote:

Also I just realized that the toplist sorting is based on a formula using addedDate, so it's 1) not possible 2) your fault. :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.