poundbangbash / community-video-reactions-management

Sonoma introduced video reactions to video calls, on by default. This payload sets app gestures off by default.
35 stars 14 forks source link

Can't seem to add other keys #13

Closed richardwilliamson closed 5 months ago

richardwilliamson commented 6 months ago

Hello

I've attempted to add a couple of other apps that appear in the list - the profile installs, and I can see the keys in the list within the profile but the apps in question (such as QLab 5) still show reactions.

Am I missing something?

Thansk!

RIchard

swy commented 5 months ago

You didn't state that you rebooted, so possibly yes?

richardwilliamson commented 5 months ago

Hello, thanks for your response. Yeah I did reboot. Steps I tried were:

1/ install new profile, then reboot, then test 2/ delete old profile, then reboot, then install new profile, then reboot, then test 3/ Change payload version number in config, then repeat step 2, then test

It's totally possible that I'm doing something dumb - but if I inspect the profile in system preferences the keys seem to be there, and I copied those keys from the command as instructed so I just can't for the life of me work out what I'm doing wrong!!

I've attached the file I created in case you have any thoughts! other than whatsapp the other apps I included are entertainment specific so may be harder to test (note I added .txt to the file so it would attach)

group.com.apple.secure-control-center-preferences.av(1).mobileconfig.txt

swy commented 5 months ago

Line 158: reset your PayloadVersion key to 1. Looks like you might be trying to use that key as version tracking for this mobileconfig. That's not what that key defines, it's about what version of the standard the xml matches. Today, the only correct value is 1, changing it can lead to unwanted behaviors. I would forecast that none of the mcx_preference_settings are being applied.

swy commented 5 months ago

Oh wait. You're confident that during step 1, the PayloadVersion value was 1? Presuming yes, are you getting expected behavior with the payload as sourced directly from this github, no edits?

richardwilliamson commented 5 months ago

Ah interesting re the version - I seem to be getting perfect behaviour with your original file, and with the new config installed (and old one removed) I am still getting that behaviour (zoom does not show reactions) - it is very strange, I'm not sure if I need to somehow flush the old profile before installing the new one?

swy commented 5 months ago

I'm not fluent in required steps for applying/reapplying this profile type, but considering how it's only read at startup (or perhaps it's specifically user login) I think the most thorough and time efficient workflow would be -Remove profile from scope -Confirm it's pulled from testing device (removed from System Settings: Profiles) -Edit profile, save changes -Return profile to scope that includes testing device -Confirm it's seen on testing device -Reboot testing device -Test If the apps that come in the .mobileconfig are being defaulted to disabled as expected, but your additions aren't, that sounds consistent with your keys not matching the apps. I can get to a device that has ZoomISO on it later today to compare.

richardwilliamson commented 5 months ago

Thanks - I think that's what I did but will have another go. In the interests of transparency I am the main developer for zoomISO so I would love to find a fix for this!

swy commented 5 months ago

Heh, small AV tech world. I've played with zoomISO, and tested betas of Zoom on tvOS, collaborating via Andy C...

swy commented 5 months ago

Oh: look at the pattern of the existing entries: each app has a gestures-enabled and reactions-enabled key. Your version only has reactions-enabled. I added

<key>videoeffects/com-liminal-zoomISO2/reactions-enabled</key>
<false/>
<key>videoeffects/com-liminal-zoomISO2/gestures-enabled</key>
<false/>

To my MDM profile, deployed, confirmed ZoomISO had them enabled, rebooted, relaunched ZoomISO, and the Reactions entry was disabled.

richardwilliamson commented 5 months ago

Ohhhh I was indeed being stupid. I don't know why I didn't spot that. Thanks -