search

poundifdef / VirginMobileMinutesChecker

Android app which allows Virgin Mobile US customers to view how many minutes are remaining, how much they owe on the account, and when payment is due
https://market.android.com/details?id=com.jaygoel.virginminuteschecker
Other
25 stars 19 forks source link

Eclipse: 16 errors, 1 warning #23

Open gurchik opened 12 years ago

gurchik commented 12 years ago

I just forked your repository and when I opened it in Eclipse I see 16 errors and 1 warning. Here is a screenshot.

poundifdef commented 12 years ago

Ah, yes! The history here is kind of a pain - I originally used eclipse, then switched to ant, and it never again quite worked correctly with eclipse. I tried fixing it a long time ago (I even asked a stackoverflow question: http://stackoverflow.com/questions/5135763/using-android-build-xml-in-eclipse) but couldn't ever figure it out.

If you are able to create whatever magic configurations eclipse needs to be able to build this without breaking ant then I would happily merge your pull request!

gurchik commented 12 years ago

If you are able to create whatever magic configurations eclipse needs to be able to build this without breaking ant then I would happily merge your pull request!

What pull request?

poundifdef commented 12 years ago

Assuming that your eclipse android environment is set up correctly (doc for how to do this is welcome :), hopefully eclipse is trying to use the android sdk rather than 'normal' java?) this may be fixable by adding @Override in the necessary places.

poundifdef commented 12 years ago

@derekmaciel I mean to say, if you fix it and make a pull request, that would be a worthwhile addition to this code base.

gurchik commented 12 years ago

@poundifdef To be quite honest, I haven't really used the Android SDK before, so I simply followed the instructions on this page.

Once I got Eclipse and the SDK set up according to the guide, I imported your project into Eclipse and it immediately started complaining about "Unable to resolve target android-8". In other words, Eclipse was given a project-specific setting for the SDK but couldn't find it. The culprit was the local.properties file: it was pointing toward your android-sdk path, but of course, not everyone would have your android-sdk path. As the top of the file states, it should be kept private to whomever created it, and it shouldn't be tracked by VCS, so I deleted and untracked it (in fact, if you've noticed, I made that commit earlier today).

It then complained about a lack of a required folder: gen. Right clicking on the project in Eclipse and selecting Android Tools -> Fix Project Properties solved this, and generated a gen folder, with two files inside.

I also noticed that removing @Override from the places it mentions in the errors got rid of the errors. It looks like you simply added that when it wasn't needed.

Then the warnings of course are trivial. Packages are being imported, but not actually used, and so, I didn't even touch them, since they're not errors, just warnings.

Now, I don't know if any of this broke Ant, but this is exactly what I did to solve the errors.