Open pountzas opened 3 years ago
Hi dear student,
Good job so far! You still need to work on some issues to go to the next project, but you are almost there!
You used proper GitHub Flow ✔️ Your linter checks are all passing ✔️ Your PR messages are descriptive ✔️
[x] According to the project, the number of the tasks for this project should be 17 for 2 members group, and you've more than this, please work on it. 🐱
At the same time, I just check that some tasks aren't assigned, but maybe that's the tasks that you need to delete, please, after having 17 tasks on your project, check that all tasks are assigned. 🐶
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, you can request a second opinion using this form.
Hi there,
Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, you can request a second opinion using this form.
https://github.com/pountzas/space-travelers-hub-react/projects/1
we are 2 persons doing this project.