pouriap / Grabby

A browser extension for downloading files and media from websites
Mozilla Public License 2.0
35 stars 2 forks source link

Option to disable checking available download managers on add-on start #10

Open siamak2 opened 1 year ago

siamak2 commented 1 year ago

Hi Right now every time add-on or Firefox starts, Grabby checks for available download managers. I'm using Jdownloader and there are times when Jdownloader is not running or updating and I open Firefox and because Jdownloader's API is not available, Grabby will not detect it. What I'm asking is to add a checkbox to settings page. if it's checked, check for available download managers on add-on start (current behavior) and if it's unchecked, load previously discovered download managers from local storage. Probably a button is needed to discover download managers in case that checkbox is unchecked.

pouriap commented 1 year ago

That makes sense but I'm pretty sure it's only an issue for network-based download managers like Jdownloader.

I might fix this in the future after I have addressed more important/mainstream issues but in the meantime you can open the options page and your list of download managers will be refreshed. So no need to restart Firefox or the addon to refresh the list. Actually the reason I have added that socket timeout to advanced options is because network-based DMs took too long to respond and the options page would take too long to load as a result.