pouriap / Grabby

A browser extension for downloading files and media from websites
Mozilla Public License 2.0
34 stars 2 forks source link

Thunder error exit #3

Closed speeed001 closed 1 year ago

speeed001 commented 2 years ago

Download chosen Thunder Closing Firefox will also cause Thunder to exit

Please fix it. thank thunder link :https://xl11.xunlei.com/

pouriap commented 2 years ago

Hi.

Thunder is not officially supported. In fact I couldn't even find it online. Until now thanks to you.

It looks like it only supports Chinese language. I couldn't even open the site, I had to use a Hong Kong VPN to download it. So it might not be that easy to integrate it. But I will try.

Recently I've been revisiting this addon and trying to finally add the media grabbing feature into it which lets you download videos too. I don't promise a new release anytime soon but I will definitely add Thunder to my to-do list.

Thanks for bringing this into my attention.

benzBrake commented 2 years ago

I'm using this extension with thunder version 11 on Windows 11, but I can't repoduce this error, can you provide more information to reproduce this error, usch as windows version, the steps to reproduce this error?

speeed001 commented 2 years ago

I'm using this extension with thunder version 11 on Windows 11, but I can't repoduce this error, can you provide more information to reproduce this error, usch as windows version, the steps to reproduce this error? win11 22000.795. I can reproduce this problem on my laptop and PC gif

pouriap commented 1 year ago

This should only happen when Thunder is closed and is opened when you start a download in Firefox. You should open Thunder first, or set it to start with windows, and then when you exit Firefox it shouldn't get closed.

pouriap commented 1 year ago

I changed the method that launches the download managers in v0.62 and it doesn't happen anymore.

There is a possibility that the new method might create other bugs. If it doesn't then this issue will be solved. If it does then I'll have to go back to the previous method and you'll have to start download managers before opening Firefox.