pourmand1376 / obsidian-custom-font

A plugin to set custom font for obsidian
https://obsidian.md/plugins?id=custom-font-loader
Apache License 2.0
49 stars 1 forks source link

Fonts not syncing #4

Open w-zhiwei opened 7 months ago

w-zhiwei commented 7 months ago

I'm not sure if it's a bug or intended, but if I put fonts folder in .obsidian, it will not be syncing at all.

pourmand1376 commented 7 months ago

How do you sync your files? Are you using obsidian sync?

w-zhiwei commented 7 months ago

How do you sync your files? Are you using obsidian sync?

Yes, im using the official sync. My current workaround is to mannually set the value of font_folder_path in the source code.

pourmand1376 commented 7 months ago

Hmm, This is something that I haven't considered.

What path did you set to fix the issue?

w-zhiwei commented 7 months ago

Hmm, This is something that I haven't considered.

What path did you set to fix the issue?

I just set const font_folder_path = "fonts" to put the fonts folder outside .obsidian. I think maybe there could be an option for users to set the font folder dir themselves.

pourmand1376 commented 7 months ago

Hmm, This is something that I haven't considered. What path did you set to fix the issue?

I just set const font_folder_path = "fonts" to put the fonts folder outside .obsidian. I think maybe there could be an option for users to set the font folder dir themselves.

This could be a good fix. Thanks for submitting the issue.

diatche commented 4 months ago

I'm having a related issue, where on iOS the fonts folder is not being found even though it's definitely there in the file tree (visible via Working Copy). The message displayed on Obsidian startup is:

"Error: The file "fonts" couldn't be opened because there is no such file."

On iOS, I've configured Obsidian to use .obsidian.mobile instead of .obsidian, which might be causing this.

iOS Version: 17.2.1 Model: iPhone 11 Pro Max

On Mac its working fine.

pourmand1376 commented 4 months ago

Currently, I put the font files inside .obsidian/fonts. I think this would be resolved if I make this path customizable.

I would add that functionality as soon as I can.

Also, I would appreciate it if anybody could make a PR.

pourmand1376 commented 3 months ago

New Version is released here.

image

You can test it by downloading main.js file and replacing with current main.js file in plugins/custom-fonts-loader folder.

The option to choose font folder path is added. I'd love to hear your feedback!