Test problems after new RefactoringMiner update

[pouryafard75]

Six tests are now failing as a result of the recent commit (https://github.com/tsantalis/RefactoringMiner/commit/41eb4a9e52e70ebc7c41bfddc5834d4162e9d61f )

• [x] case1: https://github.com/spring-projects/spring-boot/commit/20d39f7af2165c67d5221f556f58820c992d2cc6 VcapApplicationListener.java

Before:

After:

• [x] case2: https://github.com/BroadleafCommerce/BroadleafCommerce/commit/9687048f76519fc89b4151cbe2841bbba61a401d AdminAbstractController.java

Before:

After:

• [x] case3: https://github.com/JetBrains/intellij-community/commit/e1f0dbc2f09541fc64ce88ee22d8f8f4648004fe RepositoryAttachHandler.java

Before:

After:

• [x] case4: https://github.com/HdrHistogram/HdrHistogram/commit/0e65ac4da70c6ca5c67bb8418e67db914218042f HistogramLogProcessor.java

Before:

After:

• [x] case5: https://github.com/JetBrains/intellij-community/commit/98ecc4cfd927f388645f6a6bc492c80868b1a11d CreateResourceBundleDialogComponent.java

Before:

After:

• [x] case6: https://github.com/apache/camel/commit/cb0935e3af05b333b5c85a4fb3b1846836218f11 QuartzComponent.java

Before:

After:

[pouryafard75]

@tsantalis Case 1: The test case must be updated, the new diff is preferred Case 2: The previous diff is preferred. Case 3: The previous diff is preferred. Case 4: Not clear Case 5: The test case must be updated, the new diff is preferred. Case 6: The previous diff is preferred.

Please confirm. For cases 2,3,6 should I apply post-processing logic or do you plan to fix the statement mapping on your end?

[tsantalis]

@pouryafard75 I think I understand what is the problem. I will fix it.

[tsantalis]

@pouryafard75

case1: We keep After (works) case2: We keep Before (works) case3: We keep Before (works) case4: We keep After (works) The initializer diff looks weird, but the variable declaration should be mapped case5: We keep After (works) case6: We keep Before (works)

[tsantalis]

@pouryafard75

For case 4. the whole initializers should be red and green, respectively.

[pouryafard75]

@tsantalis I have fixed it in #60. Also, the PR https://github.com/tsantalis/RefactoringMiner/pull/425 has been updated.

[tsantalis]

@pouryafard75 I think if the initializer is an extracted method call (and we can get this info from the ExtractOperationRefactoring), we should have the whole initializers as deleted/added.