Argument Mappings Failing after new RefactoringMiner update - Githubissues

pouryafard75 / RM-ASTDiff

MIT License

2 stars 1 forks source link

Argument Mappings Failing after new RefactoringMiner update #59

Closed pouryafard75 closed 1 year ago

pouryafard75 commented 1 year ago

Based on https://github.com/tsantalis/RefactoringMiner/issues/419#issuecomment-1481763010, the logic for argument mapping has been changed in https://github.com/tsantalis/RefactoringMiner/commit/723188134e526474380b3ec2923ce3de2bcac2c0, thus the following test cases are not passing anymore.

[x] Case1: https://github.com/crashub/crash/commit/2801269c7e47bd6e243612654a74cee809d20959

Before the fix:

After the fix:

[x] Case2: https://github.com/JetBrains/intellij-community/commit/e1625136ba12907696ef4c6e922ce073293f3a2c MavenProject.java

Before the fix:

After the fix:

tsantalis commented 1 year ago

@pouryafard75 I reverted this commit. I need to think of a different solution.

tsantalis commented 1 year ago

@pouryafard75 Can you check after my new fix. Everything should be fine now.

pouryafard75 commented 1 year ago

@tsantalis Problems related to argument mappings have been fixed.