pouryafard75 / RM-ASTDiff

MIT License
2 stars 1 forks source link

Missing sub-expression match with conditional expression #63

Closed tsantalis closed 1 year ago

tsantalis commented 1 year ago

https://github.com/signalapp/Signal-Android/commit/c4a37e38aba926c2bef27e4fc00e3a4848ce46bd

DRAFT.IMAGE should have been matched with the conditional expression else part.

Screenshot from 2023-03-30 08-05-58

pouryafard75 commented 1 year ago

@tsantalis RefactoringMiner doesn't report the last sub-expression mapping:

Screenshot 2023-04-01 at 4 06 06 PM

Could you please verify?

pouryafard75 commented 1 year ago

@tsantalis I have replicated the example here https://github.com/pouryafard75/TestCases/commit/929055779b332d08cfb9a0f78ffb53f884a1c73c

tsantalis commented 1 year ago

@pouryafard75

Fixed

Screenshot from 2023-04-03 10-33-35