pouryafard75 / RM-ASTDiff

MIT License
2 stars 1 forks source link

Not all differences are highlighted in case of multi-mappings #82

Closed tsantalis closed 1 year ago

tsantalis commented 1 year ago

https://github.com/tsantalis/RefactoringMiner/commit/68319df7c453a52778d7853b59d5a2bfe5ec5065

4 duplicated code fragments are extracted to createLeafMappings()

intersection2 -> intersection is not highlighted 2x split -> provider is not highlighted 2nd merge -> provider is not highlighted 2x subConditionMap -> subConditionMap2 is not highlighted

Screenshot from 2023-05-25 14-34-02 Screenshot from 2023-05-25 14-34-17

pouryafard75 commented 1 year ago

@tsantalis The argument mapping of the extract method seems to be wrong.

image

To verify it, I checked the diff without the argument mappings and this is the output that seems to be correct:

image