How are these return false; statements get matched?

[tsantalis]

https://github.com/thymeleaf/thymeleaf/commit/378ba37750a9cb1b19a6db434dfa59308f721ea6

These two return false; statements shouldn't be matched. @pouryafard75 Is this related to matching the remaining unmatched statements?

[pouryafard75]

Yes, they are identical blocks and they are matched by the MissingIdenticalSubTree matcher. You can disable this matcher by commenting out the code (Lines 62-65 in the ProjectASTDiffer) I will also add a constraint to avoid block matching in this phase.

[pouryafard75]

@tsantalis Fixed https://github.com/pouryafard75/RM-ASTDiff/commit/642c22949230186386989fb4eed651c3bbe5e66a

[tsantalis]

@pouryafard75 The rule is too strict perhaps. I would exclude common return statements with default values return true return false return null return NumberLiteral

[tsantalis]

@pouryafard75 This is also related to the same problem, I think https://github.com/tsantalis/RefactoringMiner/issues/517#issuecomment-1672406988

[pouryafard75]

@tsantalis Fixed