search

poush / H2

Supporting light weight extensions for heavy task lifting
MIT License
16 stars 32 forks source link

Tray Menu added #48

Closed saravanan10393 closed 5 years ago

saravanan10393 commented 5 years ago

Tracking Issue: #40

Added a storage util so save and retrieve the user preference (eg. always keep the window on top) that set using tray menu.

Added the ALT+SHIFT+T shortcut key binding to bring the window on top.

saravanan10393 commented 5 years ago

Build failed duo to system error. The command "brew install wine" failed and exited with 127 during .

poush commented 5 years ago

Can you explain the logic behind the storage module? We would definitely need it for several other purposes as well but would like to know the use of it in this PR

poush commented 5 years ago

@saravanan10393 A quick look showed me that you were using the storage class to store the config for "alwaysOnTrue". The issue is that it actually is not the config but the core part of H2. So, please remove the Storage concept from this PR and this storage class is something which we definitely need so please create a new Issue and PR for the storage class itself

saravanan10393 commented 5 years ago

@poush , I thought like, it is necessary to have user preferences. keep window always on top is the user preference, next time when opens the it should obey the user option that has choosan earlier so that i added the store.

Ok i will create a new issue and give a pull request separately for storage.

poush commented 5 years ago

Agree, that app should remember the user preferences but it's just that "alwaysOnTop" is not a configuration. Even this key combination is temporary until it is properly fixed. The core idea behind the app is to have an embeddable browser that always keeps itself on picture-to-picture mode.

saravanan10393 commented 5 years ago

@poush removed the storage files.

saravanan10393 commented 5 years ago

@poush done the changes you have mentioned