search

poush / H2

Supporting light weight extensions for heavy task lifting
MIT License
16 stars 32 forks source link

Instead of throwing error, external links should be opened on same window #52

Closed poush closed 5 years ago

poush commented 5 years ago

We are currently throwing error in alert form when an external link is clicked. Instead of this we can make this process smoother by sending that URL to providers module which will eventually load the require link on the H2.

jfstn commented 5 years ago

I'll take care of this.

poush commented 5 years ago

Sure!

jfstn commented 5 years ago

Hello again, need some clarification. The error is no longer being thrown but load any external link means being able to navigate to any link inside H2?

poush commented 5 years ago

load any external link means being able to navigate to any link inside H2?

Yes, when you click any link that opens a new window, that must be prevented and that is already done but instead of showing an alert, we should open that on the same window. This can be done by passing the new url to providers module call as being done when ctrl/cmd+shift+v is called.