search

poush / H2

Supporting light weight extensions for heavy task lifting
MIT License
16 stars 32 forks source link

Improve the providers, add support for authentication #56

Open poush opened 5 years ago

poush commented 5 years ago

Currently, providers start with some basic methods by implementing the baseMediaProvider class. What we have to do is to improve the providers on two things:

  1. Conventions: We have to make sure file names are good, conventions are taken care of in files names as well as in the coding style and therefore fix them.

  2. Add Support for authentication: Consider those websites which have the requirement for authentication to access the specific resource requested. Now, we might not be able to automate due to several reasons including CSRF but can we improve the experience. Suppose, the user wants to use Netflix in the H2 app and if the user tries to paste the URL of a specific movie, and we open it as a link then it will be redirected to login page. The issue is that in many cases after login user gets redirected to the home page instead of the original URL. Currently, I don't have the exact solution to this, we have to find one which can enhance the experience.

poush commented 5 years ago

Meanwhile, point 2 is being discussed, anyone can take the first one to submit PR.

saravanan10393 commented 5 years ago

@poush can we add linting for code style

poush commented 5 years ago

@poush can we add linting for code style

yes and I think LGTM will also work on linter config.