search

poush / H2

Supporting light weight extensions for heavy task lifting
MIT License
16 stars 32 forks source link

Consider using a different video player #78

Open saskakol opened 5 years ago

saskakol commented 5 years ago

Perhaps it would be worth considering using a video player other than YouTube's iframe API. One that I found recently is called Plyr. (I haven't tried it myself though, so can't confirm if it's suitable.) The advantage would be more control over the look of the player, and if the player supports different video sources(Plyr apparently supports YT, Vimeo, and HTML5 video) the APIs to control the playback would be standardised (so no writing separate code to control YouTube video versus an HTML5 video link for example)

poush commented 5 years ago

Seems interesting. It will be great to see if this can also play those music videos which can't be played through embed links.

saskakol commented 5 years ago

@poush Not sure If it’s able to, YouTube might just be restricting what domains the videos can be played from.

poush commented 5 years ago

I am not sure but if we play such videos through codepen, it works.

On Thu 25 Oct, 2018, 3:28 PM Saska Kolehmainen, notifications@github.com wrote:

@poush https://github.com/poush Not sure If it’s able to, YouTube might just be restricting what domains the videos can be played from.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/poush/H2/issues/78#issuecomment-432990758, or mute the thread https://github.com/notifications/unsubscribe-auth/ABumcl6OhuytLSHr2a44KvtG8_yy-SNdks5uoYs8gaJpZM4X2NoH .

iblacker commented 5 years ago

I have tried implementing Plyr on H2 and it didn't some the issue "Video Unavailable". It has to do with certain videos being embedded in a localhost as opposite to a web server.

saskakol commented 5 years ago

@iblacker Do you think it would work with a locally hosted web server?

iblacker commented 5 years ago

I don't think it would. I can look into it later, though. Those videos work if you open the video's page, but not when it is embedded.

poush commented 5 years ago

The only way I could think right now is to open the youtube page directly for such videos and zoom on video player.