search

pouya-eghbali / sia

Sia - Binary serialisation and deserialisation
131 stars 8 forks source link

extract correct constructor from object #4

Closed zircon63 closed 2 years ago

zircon63 commented 2 years ago

Fix to correct serialization for example below: [ { "constructor": "ScrollAction", "event": { "constructor": "Event", "target": { "cssSelector": null }, "typeArg": "scroll", "eventInit": { "bubbles": true, "cancelable": false } }, "timeout": 10000, "x": 0, "y": 900000 } ]

where "constructor" is key of serialized object.

sannysoft commented 2 years ago

@pouya-eghbali The PR is much awaited, can you please approve it and release a new version. Thanks!

pouya-eghbali commented 2 years ago

@pouya-eghbali The PR is much awaited, can you please approve it and release a new version. Thanks!

Will do later today when I'm at my desk, thanks for the PR!

codecov[bot] commented 2 years ago

Codecov Report

Merging #4 (e547a8d) into master (64eab3c) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master        #4   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          444       444           
  Branches        86        86           
=========================================
  Hits           444       444
Impacted Files Coverage Δ
index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 64eab3c...e547a8d. Read the comment docs.

pouya-eghbali commented 2 years ago

@zircon63 @sannysoft merged and released, thanks for the PR!