search

pouyakary / ProColors

A collection of coding themes for syntax highlighting and the editors that are designed to be available in dark and light modes with a very high precision of harmony and token definition coverage.
https://marketplace.visualstudio.com/items?itemName=karyfoundation.theme-karyfoundation-themes
GNU General Public License v3.0
109 stars 10 forks source link

Php highlighting "broken" in 12.0.0? #11

Closed m-thorsen closed 7 years ago

m-thorsen commented 7 years ago

Methods, statics, strings, arrays, even the brackets are all green (to me at least).

Before (11.1.0): karytheme-old

After (12.0.0): karytheme-new

coastermcgee commented 7 years ago

I believe this is caused by the recently added scope for text.html.php which was implemented to colorize text and strings for php. Since most php scopes are missing from the theme, everything is falling back to using this newly added scope and that's causing the vast amount of green you're seeing.

pouyakary commented 7 years ago

@m-thorsen thanks for reporting @coastermcgee thanks for your comment, it was really helpful

Problem with PHP is we have no PHP users in KF and as I mentioned in #8 I don't know PHP so what I did was using a sample code containing most of the features from Learn X in Y minutes and it actually worked great with that sample I'll be making a go back to v11 to fix this and try to make it better. Sorry for this problem