pouyakary / ProColors

A collection of coding themes for syntax highlighting and the editors that are designed to be available in dark and light modes with a very high precision of harmony and token definition coverage.
https://marketplace.visualstudio.com/items?itemName=karyfoundation.theme-karyfoundation-themes
GNU General Public License v3.0
109 stars 10 forks source link

keep the activebar black in kary-light #16

Closed transtone closed 7 years ago

transtone commented 7 years ago

like the dark bar on top of github.com, leave a dark bar in the left is a design principles of contrast. when the left activebar is dark, it can't bother me when coding.

as robin williams says in Non-Designers-Design-Book:

Contrast on a page draws our eyes to it; our eyes like contrast. If you are putting two elements on the page that are not the same (such as two typefaces or two line widths), they cannot be similar—for contrast to be effective, the two elements must be very different.

pouyakary commented 7 years ago

Hi @transtone. Thanks for using Kary Themes. We love ideas on the theme but this one has been one of our main design principles not to have an active bar with dark background.

Contrast is good however that much contrast is bad. Contrast must be of some level not opposite of a color. If you look at the light theme there's a contrast on colors between the editor and sidebar / active bar. Also we have made several issues on the vscode's main repo and brought a better support of contrast borders and all the parts that needs to be separated are now separated using contrast borders instead of contrast color.

Still the only two distinct parts that are now in one level of color are the active bar and side bar. Our theme renders poor on vscode 12. if you get the vs 13 you'll see improvements by some order and hope the contrast borders get better in your editor so that you find the contrast comforting and not bothering.