search

pouyakary / ProColors

A collection of coding themes for syntax highlighting and the editors that are designed to be available in dark and light modes with a very high precision of harmony and token definition coverage.
https://marketplace.visualstudio.com/items?itemName=karyfoundation.theme-karyfoundation-themes
GNU General Public License v3.0
110 stars 11 forks source link

Support Zed editor #41

Open elvinaspredkelis opened 8 months ago

elvinaspredkelis commented 8 months ago

Hey,

I love this theme and I have been using it with VSCode for quite a while already. However, I've moved recently to Zed and I really miss this theme.

Is there a way to port it over there?

Thanks!

pouyakary commented 8 months ago

@elvinaspredkelis hey! I have no idea! I mean I tested Zed last week after a while and spotted the possibility to create themes, but I have no idea if that is possible. Pro Colors was made with the hope to be a universal theme, (I even wrote themeX for that reason) but then supporting more and more languages in high quality made it more and more tied to the vscode language specifications.

I have not had the time to investigate how Zed's theming works, and find it very improbable to want to develop Pro Colors for it any time soon. Honestly, I already have too little time for the things that I want to do, and I'm heavily trying to prioritize them, adding anything as huge as this is not in my mind.

If you want the theme, you can port it to Zed, or contribute a Zed Adapter to themeX, if you do that, I'd be happy to officially support Zed, but I don't have the time to do it my own sadly.

pouyakary commented 8 months ago

For my curiosity I checked a theme and tried to see how it is tokenized, the theme has very similar token scopes to tmLanguage:

https://github.com/zed-industries/zed/blob/main/assets/themes/rose_pine/rose_pine.json

It means that the current rules in Pro Colors can be used if you write a themeX adapter.

pouyakary commented 8 months ago

For my curiosity I checked a theme and tried to see how it is tokenized, the theme has very simialr token scopes to tmLanguage:

https://github.com/zed-industries/zed/blob/main/assets/themes/rose_pine/rose_pine.json

It means that the current rules in Pro Colors can be used if you write a themeX adapter.

elvinaspredkelis commented 8 months ago

@pouyakary

Totally understandable. Will look over how themeX works and see whether I'll be write an adapter for Zed.

Or, maybe I'll open an issue on Zed's repository and someone might be interested in taking a stab at it as well.

Anyway, thanks for this theme! 🙌

pouyakary commented 8 months ago

@elvinaspredkelis you're very welcome. BTW, I have moved to Zed as well, and created a new very minimal and very different theme which I will open source once is good enough. Once I do, I'll definitely post a link here.

kucrut commented 4 months ago

I've been using the Light Pro Colors theme on VSCode for years and nothing comes close to it - thank you!

I tried Zed the other week after the Linux version went public and I really liked it. However, I had to go back to VSCode as I couldn't stand the available light themes it offers, so yeah, I'd also love to use Zed with Pro Colors theme. No pressure though, take as much time as you need :)