search

pouyakary / TextGraphic

TextGraphic is a framework for creating Textual Graphics. It provides layers, styling, rich color, text justification, layouts, tables, view-ports, transparency, etc.
Mozilla Public License 2.0
104 stars 2 forks source link

Chart Ruler has invalid spacings in the initiation ShapeView #3

Open pouyakary opened 3 years ago

hosseind88 commented 3 years ago

can I work on this issue?

pouyakary commented 3 years ago

You can certainly try. The bug is in the ./textkit/source/shapes/rulers/chart-rulers.ts. The ShapeView object expects its init lines to be the same length. The h-ruler has has two lines (one the ruler and one the numbers). You have to figure out which line is not spaced right.

You have to write the code with the KCS applied to it. It is a small bug, so if you don't apply KCS it will be far easier for me to just fix it instead of reviewing your code. You can also play around with the rulers in the ruler playground