fixes #98 - Githubissues

povils / phpmnd

PHP Magic Number Detector

MIT License

554 stars 46 forks source link

Open SignpostMarv opened 4 years ago

SignpostMarv commented 4 years ago

d31251f applies the actual fix for #98
18df263 is to make sure that d31251f didn't break anything
e42db9b is to fix a build failure caused by deprecated ReflectionType::__toString() usage.
b724f9a & 309a88e are to allow install alongside phpunit 9

SignpostMarv commented 4 years ago

scrutinizer / appveyor failures do not appear related to changes made.

juliangut commented 4 years ago

Do not understand why #101 #102 and #104 are not yet merged

exussum12 commented 3 years ago

@SignpostMarv The build is failing any chance you can look ?

SignpostMarv commented 3 years ago

@exussum12 currently awaiting return of computer so I can work on dev things again.

SignpostMarv commented 3 years ago

@exussum12 computer returned today, will need to schedule time this week to look at a rebase/merge

exussum12 commented 3 years ago

looks good to me. Thanks.

@sidz happy with this one ?

SignpostMarv commented 3 years ago

it's probably worth mentioning that as this PR is a little over a year old, I've lost the original context for when the issue occurs 🤷‍♂️

sidz commented 3 years ago

@SignpostMarv I assume that there were some incompatibility issues with newest symfony/console.

Currently we need to bump up minimum version of symfony/console to 4.4 as current 4.0 has some incompatibilities with PHP 7.4.

we will do it in separate branch