search

povils / phpmnd

PHP Magic Number Detector
MIT License
554 stars 46 forks source link

Update to allow installing with up coming php 8.0 release #117

Closed timhaak closed 3 years ago

timhaak commented 4 years ago

Hi

I'm getting ahead of getting ready to test with PHP 8.0.

So this is one of the packages that broke for me.

I've set it, composer, to also support PHP 8.0.

Unfortunately, it doesn't look like Travis as support for 8.0 testing yet or I couldn't work out the magic string.

I have put the rules in uncommented.

I've also removed the 7.4 --prefer-lowest check as PHPUnit 7 breaks with PHP 7.4.

timhaak commented 4 years ago

Looks like something is unfortunately broken with chocolatey or AppVeyor where the current AppVeyor script doesn't seem to be able to set different PHP versions :(

povils commented 4 years ago

Hey! thanks for the PR :) let me take a look at CI and see if I can make it great again :D

SmetDenis commented 3 years ago

Hey. How is it going? Any news about PHP 8 so far? :)

sidz commented 3 years ago

For those who are looking compatibility with PHP 8:

I forked this repo as looks like maintainer busy or stopped maintaining this project and released a new version with PHP 8 compatibility.

https://github.com/sidz/phpmnd

p.s. I'm okay to backport all future changes back to this repo or archive my folk in favor of original authors repo in case maintainer back.

povils commented 3 years ago

Hey thanks for the PR! i merged https://github.com/povils/phpmnd/pull/121 this one. I will work on removing travis and switching to GA.

sidz commented 3 years ago

implemented in https://github.com/povils/phpmnd/pull/121