search

povils / phpmnd

PHP Magic Number Detector
MIT License
554 stars 46 forks source link

Add checkstyle printer #139

Open sasezaki opened 3 years ago

sasezaki commented 3 years ago

This PR requests adding checkstyle output feature.

I need checkstyle output to work with cs2pr, and other QA tools.

Notes: This PR also inclueds cs-fix

exussum12 commented 3 years ago

Would prefer this to be an output=xml or output=checkstyle.

You could pass both flags currently which would be strange- Checkstyle is a great idea though

sasezaki commented 3 years ago

Would prefer this to be an output=xml or output=checkstyle.

Not sure if these should be printed to stderr ?

I will try refactor (includes BC breaks) output format on another PR branch.

povils commented 3 years ago

Would prefer this to be an output=xml or output=checkstyle.

You could pass both flags currently which would be strange- Checkstyle is a great idea though

I also see this as just a different output