povils / phpmnd

PHP Magic Number Detector
MIT License
554 stars 46 forks source link

Option to disable the highlighter #140

Open exussum12 opened 3 years ago

exussum12 commented 3 years ago

Running on large files is quite slow, about 50% of the time is taken highlighting the code.

Total of Magic Numbers: 8 Time: 00:01.485, Memory: 94.01 MB

And commenting https://github.com/povils/phpmnd/blob/master/src/Printer/Console.php#L38-L41

takes it to

Total of Magic Numbers: 8 Time: 00:00.755, Memory: 56.00 MB

Anyone got an opinion on the formatting ? It highlights php code in general, if anything I think we should highlight the number.

Either way an option to save 50% processing would be quite a nice one to provide