search

povils / phpmnd

PHP Magic Number Detector
MIT License
550 stars 46 forks source link

Command Refactoring #143

Closed sidz closed 2 years ago

sidz commented 2 years ago

This PR brings a bit of refactoring in the Application and Command classes as well as improving CommandTest and use symfony CommandTester instead of mocking and using Reflection.

An additional: we got rid of message: The at() matcher has been deprecated. It will be removed in PHPUnit 10. Please refactor your test to not rely on the order in which methods are invoked.

RunCommandTest is a functional test instead of Unit.

sidz commented 2 years ago

@exussum12 rebased. need to be reviewed one more time please.

exussum12 commented 2 years ago

sorry for slow reply. LGTM :+1: nice work

sidz commented 2 years ago

thanks @exussum12. merged.