search

povils / phpmnd

PHP Magic Number Detector
MIT License
554 stars 46 forks source link

Application Refactoring #145

Closed sidz closed 2 years ago

sidz commented 3 years ago

This PR brings a lot of changes to PHPMND.

Reducing memory usage and speed up scanning a bit. Real example on my current project: current master:

Total of Magic Numbers: 17
Time: 00:06.161, Memory: 32.00 MB

This PR:

Total of Magic Numbers: 17
Time: 00:05.373, Memory: 28.00 MB
exussum12 commented 3 years ago

Still going though these, I will mark as hacktober accepted in case you are participating, changes look good though

sidz commented 2 years ago

@exussum12 sorry for disturbing. how is review going?

exussum12 commented 2 years ago

Apologies I've been away. I can take a proper look tomorrow

exussum12 commented 2 years ago

This is a mega refactor! Im going though the list now to try and verify its not caused any issues. Nice work some really nice changes in there

exussum12 commented 2 years ago

Approved. Nice work

sidz commented 2 years ago

Thanks @exussum12