search

povils / phpmnd

PHP Magic Number Detector
MIT License
554 stars 46 forks source link

Remove --non-zero-exit-on-violation option #152

Closed sidz closed 2 years ago

sidz commented 2 years ago

This PR drop support of --non-zero-exit-on-violation option.

The argument is: phpmnd is mostly used in CI where it must fail builds in case any violation is detected so it does not make a lot of sense to use in CI and skip violations.

exussum12 commented 2 years ago

This is for 3.0 really, its a breaking change in the pipeline especially for incremental analysis

sidz commented 2 years ago

@exussum12 yup, everything what I'm going to do now is for 3.0 :)

sidz commented 2 years ago

Thanks @exussum12