search

povils / phpmnd

PHP Magic Number Detector
MIT License
554 stars 46 forks source link

Micro optimization to reduce array_merge calls #170

Closed sidz closed 11 months ago

sidz commented 1 year ago

Not a big win but this is a micro optimization will reduce amount of array_merge calls in case exclude-path or exclude-file options has more than one entry as Finder is doing array merge all the time notPath, notName, name are called.

see https://github.com/symfony/finder/blob/4.4/Finder.php#L286

sidz commented 12 months ago

Hey @sasezaki, @exussum12, @kubawerlos could you please take a look at these changes when you have a chance?

sidz commented 11 months ago

thanks @kubawerlos, @sasezaki