search

povils / phpmnd

PHP Magic Number Detector
MIT License
554 stars 46 forks source link

Enable coding standard compliance guard in Travis CI #43

Closed raphaelstolt closed 7 years ago

raphaelstolt commented 7 years ago

This is just a proof of concept for now.

Since there won't be any usage of xCIs to guard coding standard violations, utilise composer cs-check in Travis CI. The composer cs-check is only run against a single version i.e. 7.1 to keep the build fast.

If this gets an okay, I'll remove the on purpose added coding standard violation.

padraic commented 7 years ago

Would it be worthwhile hinting to folk that the CS is enforced via Travis? Maybe in CONTRIBUTING.md where they are advised to go and check it themselves?

raphaelstolt commented 7 years ago

@padraic Done via 3e5964a.

raphaelstolt commented 7 years ago

Removed coding standard violation and squashed commits into one. Good to merge.

povils commented 7 years ago

thanks