povils / phpmnd

PHP Magic Number Detector
MIT License
554 stars 46 forks source link

[WIP] Add a `self-update` command to update local phpmnd.phar from Github releases #44

Open padraic opened 7 years ago

padraic commented 7 years ago

Noted as WIP for feedback. Having a run command - there's probably a better way to have a default command (where $_SERVER['argv'] isn't manipulated outside of symfony/console). This also omits the self-update command from --help.

Works, but may need some tidying for those two points.

povils commented 7 years ago

I need to take a better look on this :)

padraic commented 7 years ago

Thanks for the review @povils - made some changes. Missed your comment on the text colouring if you have specific colour codes to fit in with your preferred theme.

padraic commented 7 years ago

@povils Pretty much done, but I may add a few changes towards the weekend to take advantage of a new phar-updater release expected shortly, and someone may know if the fugly argv function has a more...elegant solution.