povils / phpmnd

PHP Magic Number Detector
MIT License
554 stars 46 forks source link

Return non zero exit code when there are magic number in the codebase #51

Closed povils closed 7 years ago

raphaelstolt commented 7 years ago

Might need integration tests verifying the two exit return codes. Also an Added entry to the CHANGELOG.md should be included here already so you don't have to add it when releasing.

phaldan commented 7 years ago

If you return the exit-code in the execute method instead of calling exit directly, the BaseCommand will do the rest for you. Then you could test the execute method directly.

povils commented 7 years ago

Thanks guys for suggestions!