search

povils / phpmnd

PHP Magic Number Detector
MIT License
554 stars 46 forks source link

Negative numbers #57

Closed IlyaSavich closed 6 years ago

IlyaSavich commented 7 years ago

Good day, I get an issue for such case. Package doesn't recognize this like a magic number

$limit = Carbon::now()->addYears(-123123);

Interesting that with the second example works fine

$limit = Carbon::now()->addYears(123123);

As I understand it's bug or I'm wrong

povils commented 7 years ago

Hey, Thanks for the issue! Apparently, you are correct, it is a bug:) Do you want to contribute and fix one? :)

Regards

exussum12 commented 6 years ago

This looks to be resolved now so the issue can be closed ?