search

povils / phpmnd

PHP Magic Number Detector
MIT License
554 stars 46 forks source link

Check for numeric strings #69

Closed exussum12 closed 6 years ago

exussum12 commented 6 years ago

String which are simply numbers should be treated as numbers

eg '1234' should be treated like 1234.

other non numeric strings are still treated as they were

povils commented 6 years ago

First of all thanks. Secondly, I'm thinking maybe pass the option "--include-numeric-string" instead of breaking peoples CIs ? :) Also could you rebase your commits.

exussum12 commented 6 years ago

Commit rebased, its also an option on merging btw to do a rebase merge. I will look at making it an option later on today.

exussum12 commented 6 years ago

Made a command but had no idea why that test is failing, The test seems flaky to depend on the number 11 ?

exussum12 commented 6 years ago

Fixed the test

povils commented 6 years ago

Big thanks!!