search

pow-auth / assent

Multi-provider framework in Elixir
https://powauth.com
MIT License
391 stars 45 forks source link

OIDC normalize/2 to conform to OAuth2 normalize/2 #91

Closed gaiabeatrice closed 3 years ago

gaiabeatrice commented 3 years ago

I realize that the typespec for normalize/2 belonging to the OIDC strategy is different than the one described in the docs, and the OAuth2 one, and it is making my dialyzer fail.

I believe it should be changed to 

@callback normalize(Keyword.t(), map()) :: {:ok, map()} | {:ok, map(), map()} | {:error, term()}

to allow claims that don't conform to the OIDC spec

danschultzer commented 3 years ago

Good catch, thanks! Fixed in #92.

gaiabeatrice commented 3 years ago

@danschultzer can you cut a release for this, so it can fix the dialyzer errors?

danschultzer commented 3 years ago

New release is out, sorry for the delay!