search

pow-auth / assent

Multi-provider framework in Elixir
https://powauth.com
MIT License
391 stars 45 forks source link

Update slack to use OIDC #97

Closed danschultzer closed 2 years ago

danschultzer commented 2 years ago

Unfortunately this introduces a breaking change to the sub field, as it now no longer include the team id.

tomsharratt commented 2 years ago

Can this be merged?

MMore commented 2 years ago

Hey @danschultzer, what do you think about my proposal to get team_id? That would mean it's not a breaking change anymore.

danschultzer commented 2 years ago

@MMore I've added a :userinfo_additional_claims setting so additional claims can be added. For Slack it'll add the team id claim automatically now 😄

MMore commented 2 years ago

@danschultzer Very good. So we have the team_id available! Can we go back to the prior {SUB}-{TEAM} structure or do you see a reason not to do it?

danschultzer commented 2 years ago

@MMore No, since Slack already provides a unique id. It's unfortunate, but I'll see if I can provide instructions in the changelog for how to dynamically update the id. This is a breaking change with 0.2.0.

danschultzer commented 2 years ago

I've added a module example for how to continue using the old sub user id value. Migration is very dependent how the logic has been set up.

danschultzer commented 2 years ago

v0.2.0 has been released with this 🎉 The changelog contains an example for how to continue using the old user id format, if you don't want to deal with migrating the user id.