pow-auth / pow_assent

Multi-provider authentication for your Pow enabled app
https://powauth.com
MIT License
321 stars 50 forks source link

Extract :cache_store_backend from :pow config #198

Closed DianaOlympos closed 3 years ago

DianaOlympos commented 3 years ago

Pow_assent does its own session handling. In a multi node scenario, if this is not done, the callback could end up in a different node, failing to authenticate.

We could better call out this configuration... or just use the one from Pow. Which probably make sense? not sure, would love to hear what you think or what i am missing here.

danschultzer commented 3 years ago

Great catch, thanks! I forgot this with https://github.com/pow-auth/pow_assent/pull/135

danschultzer commented 3 years ago

Hmm, looking at this, it does seem that the :cache_store_backend is pulled correctly. It's pulled from the pow config rather than the pow assent config using Pow.Plug.fetch_config. It's being tested in PowAssent.PlugTest. How did you encounter this issue?

danschultzer commented 3 years ago

Figured it out, fixed 😄

danschultzer commented 3 years ago

v0.4.10 has been released with fix for this!