search

pow-auth / pow_assent

Multi-provider authentication for your Pow enabled app
https://powauth.com
MIT License
318 stars 50 forks source link

Fix warning on Elixir 1.12 #211

Closed Schultzer closed 3 years ago

Schultzer commented 3 years ago

After compiling a project on Elixir 1.12 then I receive this error:

warning: module attribute @impl was not set for function create/2 callback (specified in PowAssent.Ecto.UserIdentities.Context). This either means you forgot to add the "@impl true" annotation before the definition or that you are accidentally overriding this callback
  lib/pulse/accounts/user_identities.ex:3: Pulse.Accounts.UserIdentities (module)

I could not find anything mentioned in the changelog https://github.com/elixir-lang/elixir/blob/v1.12/CHANGELOG.md, that would indicate that defdelegate would produce this error when used in https://hexdocs.pm/elixir/typespecs.html#behaviours.

/edit

I think I've found the PR that introduced this: https://github.com/elixir-lang/elixir/pull/10682

danschultzer commented 3 years ago

Thanks, v0.4.11 has been released!