search

pow-auth / pow_assent

Multi-provider authentication for your Pow enabled app
https://powauth.com
MIT License
318 stars 50 forks source link

Incorrect error flash message when logging in with no allowed registration #229

Closed olb17 closed 1 year ago

olb17 commented 1 year ago

According to doc, when registration is disabled :

If `:pow_assent_registration` in `conn.private` is set to `false` then
  `create_user/4` will not be called and the `:pow_assent_callback_state` set
  to `{:error, :create_user}` with `nil` value for
  `:pow_assent_callback_error`

The callback_upsert function should take this case into account and identify this case as nominal and not as error.

danschultzer commented 1 year ago

Thanks, and sorry for the wait!

I've refactored the fix in this PR so now it's properly tested. Users can't sign up, but can sign in. I'll get a release out soon.

olb17 commented 1 year ago

Thank you so much. I very much appreciate your work and your contribution to the elixir ecosystem.

Best regards

Le lun. 23 janv. 2023 à 04:12, Dan Schultzer @.***> a écrit :

Merged #229 https://github.com/pow-auth/pow_assent/pull/229 into main.

— Reply to this email directly, view it on GitHub https://github.com/pow-auth/pow_assent/pull/229#event-8330374499, or unsubscribe https://github.com/notifications/unsubscribe-auth/AASXBNFDCAWYSWVUS4YRWUTWTXZJBANCNFSM6AAAAAASBJRHPY . You are receiving this because you authored the thread.Message ID: @.***>