search

pow-auth / pow_assent

Multi-provider authentication for your Pow enabled app
https://powauth.com
MIT License
323 stars 50 forks source link

fix: use href attribute in deauthorization link to correctly handle D… #250

Open gildo opened 5 months ago

gildo commented 5 months ago

Hi,

This PR addresses an issue with de-authorization links. The generated link did not correctly handle the method="delete" attribute, which caused a GET request instead of DELETE.

Ref: Can't get delete links to work in Phoenix 1.7rc.

Thanks for your work.

Best, Gildo

arthurbailao commented 2 months ago

Do you think href would work in older versions of Phoenix @gildo? In that case, it should be pretty safe to merge this right?

gildo commented 2 months ago

Do you think href would work in older versions of Phoenix @gildo? In that case, it should be pretty safe to merge this right?

Hi @arthurbailao, I have made no tests on older versions of Phoenix, and I'm pretty new to the framework, but I guess that href should be backwards compatible. Let's see if the project owners can tell us more.