Develop

[1aristotelis]

Before merging to prod all wallet actions should be tested for each wallets (did not have the time to do so)

[owenkellogg]

Sensilet is not yet supported for boosting and most other transaction types, so perhaps it should be hidden for now.

[owenkellogg]

Oh I see, your currently selected wallet is highlighted when you click "Select Wallet".

[derrickhorton]

Here are the results of my review (performed today over the last 40 minutes):

PR 194 Tests:

Relay:

    Post URL:   No
    Boost Post:     Yes (takes 26 seconds)
    BitChat:    No

Twetch:

    Post URL:   No
    Boost Post: Yes (takes 15 seconds)
    BitChat:    No

HandCash:

    Post URL:   No
    Boost Post: Yes (takes 30 seconds)
    BitChat:    Yes

Sensilet:

    Post URL:   No
    Boost Post: No
    Personal Int:   No
    BitChat:    No

Local Wallet:

    Post URL:   No
    Boost Post: No
    BitChat:    No

[1aristotelis]

I don't think we know how to handle Handcash Auth error: on my local branch i don't have an Handcash App id set, so I end up in this screen :

When I go back to the settings page the handcash wallet is selected as if it was successfully signed in with handcash but it's not

Makes me think what happens for a regular user if he fails to authenticate with handcash, do we have a handcash error hook or something ?

[derrickhorton]

The settings page above looks great! It shows the user what wallet he has selected.

Good thinking about handling the situation where the user gracefully fails to authenticate with HandCash.