search

powa-team / pg_qualstats

A PostgreSQL extension for collecting statistics about predicates, helping find what indices are missing
Other
272 stars 26 forks source link

Build failure with PG12: pg_qualstats.c:47:10: fatal error: optimizer/var.h: No such file or directory #23

Closed df7cb closed 5 years ago

df7cb commented 5 years ago

Building with 12beta1:

16:13:05 gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -g -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -fno-omit-frame-pointer -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -fPIC -I. -I./ -I/usr/include/postgresql/12/server -I/usr/include/postgresql/internal  -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -I/usr/include/libxml2  -I/usr/include/mit-krb5  -c -o pg_qualstats.o pg_qualstats.c
16:13:05 pg_qualstats.c:47:10: fatal error: optimizer/var.h: No such file or directory
16:13:05  #include "optimizer/var.h"
16:13:05           ^~~~~~~~~~~~~~~~~
16:13:05 compilation terminated.
rjuju commented 5 years ago

Oups, thanks for pointing it. I already committed a fix for that some time ago but I never released it. I just pushed another fix and bumped version 1.0.8, without tagging it yet.

I'm in a business trip for 2 weeks, so I don't have my usual vm for debian packaging. I can try to push a blind debian/changelog bump for the new version, unless you want to take care of it?

df7cb commented 5 years ago

Hi Julien, I just tagged a release. Thanks!

rjuju commented 5 years ago

Thanks a lot!