search

powa-team / pg_qualstats

A PostgreSQL extension for collecting statistics about predicates, helping find what indices are missing
Other
272 stars 26 forks source link

Minor code refactoring #48

Closed tedyu closed 2 years ago

tedyu commented 2 years ago

There is no need to check the value for pgqs_resolve_oids when assigning base_size because the size of pointer should be the same.

In pgqs_get_canonical_opexpr(), variable new is renamed to newexpr since new is a keyword in C++.

Error messages for set-valued function are modified to distinguish different cases.

tedyu commented 2 years ago

cc @rjuju

rjuju commented 2 years ago

In pgqs_get_canonical_opexpr(), variable new is renamed to newexpr since new is a keyword in C.

Did you mean C++? I don't see any new C standard that made "new" a keyword.

tedyu commented 2 years ago

@rjuju Please take another look.

rjuju commented 2 years ago

Merged, thanks!