pg_qualstat compatibility with postgres 17

[pc-dok]

hi all

is the actual version from qualstat compatible with postgres 17 in this moment? or did you make a new release?

regards franco

[rjuju]

hi, the latest tag is compatible with postgres 17. I just didn't had the time to make a full release yet (I will do that tomorrow)

[pc-dok]

ok, i ask, because we try to build it into postgres 17 and have this errors, and also is than not in the lib folder: make: No rule to make target '/contrib/contrib-global.mk'. Stop. linux/system_stats_utils.c: In function ‘read_process_status’: linux/system_stats_utils.c:159:9: warning: ‘readdir_r’ is deprecated [-Wdeprecated-declarations] 159 | while (readdir_r(dirp, &dbuf, &ent) == 0) | ^~~~~ In file included from linux/system_stats_utils.c:18: /usr/include/dirent.h:183:12: note: declared here 183 | extern int readdir_r (DIR restrict dirp, | ^~~~~ linux/cpu_memory_by_process.c: In function ‘ReadCPUMemoryUsage’: linux/cpu_memory_by_process.c:230:9: warning: ‘readdir_r’ is deprecated [-Wdeprecated-declarations] 230 | while (readdir_r(dirp, &dbuf, &ent) == 0) | ^~~~~ In file included from linux/cpu_memory_by_process.c:16: /usr/include/dirent.h:183:12: note: declared here 183 | extern int readdir_r (DIR restrict dirp, | ^~~~~ linux/system_stats_utils.c:159:9: warning: 'readdir_r' is deprecated [-Wdeprecated-declarations] 159 | while (readdir_r(dirp, &dbuf, &ent) == 0) | ^ /usr/include/dirent.h:186:28: note: 'readdir_r' has been explicitly marked deprecated here 186 | nonnull ((1, 2, 3)) attribute_deprecated; | ^ /usr/include/sys/cdefs.h:331:51: note: expanded from macro 'attribute_deprecated' 331 | # define attribute_deprecated attribute ((deprecated)) | ^ 1 warning generated. linux/cpu_memory_by_process.c:230:9: warning: 'readdir_r' is deprecated [-Wdeprecated-declarations] 230 | while (readdir_r(dirp, &dbuf, &ent) == 0) | ^ /usr/include/dirent.h:186:28: note: 'readdir_r' has been explicitly marked deprecated here 186 | nonnull ((1, 2, 3)) attribute_deprecated; | ^ /usr/include/sys/cdefs.h:331:51: note: expanded from macro 'attribute_deprecated' 331 | # define __attribute_deprecated attribute ((deprecated__)) | ^ 1 warning generated. pg_qualstats.c: In function ‘pgqs_set_query_sampled’: pg_qualstats.c:529:23: error: ‘MyBackendId’ undeclared (first use in this function); did you mean ‘MyBackendType’? 529 | pgqs->sampled[MyBackendId] = sample; | ^~~ | MyBackendType pg_qualstats.c:529:23: note: each undeclared identifier is reported only once for each function it appears in pg_qualstats.c: In function ‘pgqs_is_query_sampled’: pg_qualstats.c:550:33: error: ‘ParallelLeaderBackendId’ undeclared (first use in this function) 550 | sampled = pgqs->sampled[ParallelLeaderBackendId]; | ^~~~~~~ pg_qualstats.c: In function ‘pg_qualstats_common’: pg_qualstats.c:2198:9: warning: implicit declaration of function ‘tuplestore_donestoring’; did you mean ‘tuplestore_rescan’? [-Wimplicit-function-declaration] 2198 | tuplestore_donestoring(tupstore); | ^~~~~~ | tuplestore_rescan make: [: pg_qualstats.o] Error 1 pg_qualstats.c: In function ‘pgqs_set_query_sampled’: pg_qualstats.c:529:23: error: ‘MyBackendId’ undeclared (first use in this function); did you mean ‘MyBackendType’? 529 | pgqs->sampled[MyBackendId] = sample; | ^~~ | MyBackendType pg_qualstats.c:529:23: note: each undeclared identifier is reported only once for each function it appears in pg_qualstats.c: In function ‘pgqs_is_query_sampled’: pg_qualstats.c:550:33: error: ‘ParallelLeaderBackendId’ undeclared (first use in this function) 550 | sampled = pgqs->sampled[ParallelLeaderBackendId]; | ^~~~~~~ pg_qualstats.c: In function ‘pg_qualstats_common’: pg_qualstats.c:2198:9: warning: implicit declaration of function ‘tuplestore_donestoring’; did you mean ‘tuplestore_rescan’? [-Wimplicit-function-declaration] 2198 | tuplestore_donestoring(tupstore); | ^~~~~~ | tuplestore_rescan make: [: pg_qualstats.o] Error 1 get_parsedinfo.c: In function ‘get_parsedinfo’: get_parsedinfo.c:237:9: error: implicit declaration of function ‘tuplestore_donestoring’; did you mean ‘tuplestore_rescan’? [-Werror=implicit-function-declaration] 237 | tuplestore_donestoring(tupstore); | ^~~~~~ | tuplestore_rescan cc1: all warnings being treated as errors make: [: get_parsedinfo.o] Error 1 get_parsedinfo.c: In function ‘get_parsedinfo’: get_parsedinfo.c:237:9: error: implicit declaration of function ‘tuplestore_donestoring’; did you mean ‘tuplestore_rescan’? [-Werror=implicit-function-declaration] 237 | tuplestore_donestoring(tupstore); | ^~~~~~ | tuplestore_rescan cc1: all warnings being treated as errors make: *** [: get_parsedinfo.o] Error 1

we use the: pg_qualstats-2.1.0.tar.gz

regards franco

[rjuju]

we use the: pg_qualstats-2.1.0.tar.gz

This is not the latest tag.

[pc-dok]

ok, you have right, let me try it with 2.1.1

[rjuju]

ok! I just realised that I didn't update the CI to also test pg 17, but I'm sure I manually tested it yesterday before pushing the tag.

[rjuju]

FTR I just added a real 2.1.1 version, so there shouldn't be inconsistencies between tags and version anymore.